Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global error handler cleanup - UpDown Counter, Historgram, Gauge. #2242

Merged
merged 12 commits into from
Oct 27, 2024
Merged

Global error handler cleanup - UpDown Counter, Historgram, Gauge. #2242

merged 12 commits into from
Oct 27, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 24, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 24, 2024 23:09
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.63415% with 35 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (3bc9b3d) to head (3b15802).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter.rs 14.6% 35 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2242     +/-   ##
=======================================
- Coverage   79.5%   79.4%   -0.1%     
=======================================
  Files        121     121             
  Lines      20938   20962     +24     
=======================================
  Hits       16656   16656             
- Misses      4282    4306     +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

utpilla
utpilla approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let a suggestion about using capital letter for the first letter of each instrument name. That's how we use it in the spec docs as well.

If we go this route, this will need to be updated for the previously merged PRs as well.

@lalitb
Copy link
Member Author

lalitb commented Oct 27, 2024

Let a suggestion about using capital letter for the first letter of each instrument name. That's how we use it in the spec docs as well.

If we go this route, this will need to be updated for the previously merged PRs as well.

Good point. Have updated for all the instruments.

@lalitb lalitb merged commit afc8ff5 into open-telemetry:main Oct 27, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalitb @cijothomas @utpilla